Styles/Scale: style values

[danirabbit]

Fixes #800

[danirabbit]

@wpkelso One issue here is only TOP and BOTTOM positions follow the slider, so I don't want to style LEFT and RIGHT as osd, but when I add the extends inside &.bottom, &.top the margins break. Any ideas?

[wpkelso]

One issue here is only TOP and BOTTOM positions follow the slider, so I don’t want to style LEFT and RIGHT as osd, but when I add the extends inside &.bottom, &.top the margins break. Any ideas?

@danirabbit I don't see much of a visual difference, but there seems to be an error thrown with it in its current location, while that error goes away when it is moved to be inside &.bottom, &.top. E.g.

versus

[danirabbit]

@wpkelso look at the vertical alignment of the horizontal scale in your second screenshot. It's way off center compared to the top screenshot

[wpkelso]

@danirabbit It looks like when the extends is placed inside the &.bottom, &.top the overrides for top-margin and bottom-margin aren't cascading correctly (which was probably already clear to you 😅 ). Within Gtk.css they're calculated out to the exact same rem values in the exact same place. There isn't anything further down the file that touches those values.

I haven't been able to figure out why they then get calculated to different pixel values, so maybe it's some weird edge case in rem conversion?

The following are the margins and padding for the value elements in either case. I used 1.25 text scaling on the top image, but that shouldn't create the specific behaviours here.

[wpkelso]

Thinking about it, rem calculation error is probably the wrong conclusion. It looks like the overrides just aren't getting applied for some reason.

[danirabbit]

@wpkelso I think it was fixed in #840

[wpkelso]

I think it was fixed in #840

Ah, yup, looks like it. Do we know specifically which change fixed it? Was it the thing where osds couldn't be modified?

[danirabbit]

@wpkelso yeah exactly. Setting the provider priority so that it wasn't always overriding the gtk styles

[wpkelso]

Looks all tidy to me 🚀