Skip to content

Constants: deprecate STYLE_CLASS_FRAME#844

Merged
danirabbit merged 2 commits intomainfrom
danirabbit/styles-hasframe-deprecation
Apr 17, 2025
Merged

Constants: deprecate STYLE_CLASS_FRAME#844
danirabbit merged 2 commits intomainfrom
danirabbit/styles-hasframe-deprecation

Conversation

@danirabbit
Copy link
Member

Uses of FRAME

  • with Gtk.InfoBar which is deprecated and needs a replacement widget anyways
  • with Gtk.ScrolledWindow which has a property has_frame
  • with Gtk.ListBox which should either be CARD for non-scrolled boxes or on the ScrolledWindow for scrolled boxes
  • When there's an ActionBar related to a ScrolledWindow/ListBox. This should probably be like a '.linked' style for ActionBar or a ToolBarview or something. There's also just Gtk.Frame. Lot of other possible solutions than adding a frame style to a box

@danirabbit danirabbit requested a review from a team April 17, 2025 16:15
@danirabbit danirabbit merged commit 884b029 into main Apr 17, 2025
5 checks passed
@danirabbit danirabbit deleted the danirabbit/styles-hasframe-deprecation branch April 17, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants