Skip to content

Add .monospace class#861

Merged
danirabbit merged 7 commits intoelementary:mainfrom
wpkelso:styles/monospace
May 9, 2025
Merged

Add .monospace class#861
danirabbit merged 7 commits intoelementary:mainfrom
wpkelso:styles/monospace

Conversation

@wpkelso
Copy link
Member

@wpkelso wpkelso commented May 6, 2025

No description provided.

@wpkelso wpkelso requested a review from a team May 6, 2025 17:06
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a constant in Granite.CssClass and add an example to the Demo!

@wpkelso
Copy link
Member Author

wpkelso commented May 6, 2025

@danirabbit This is a class that had a Gtk style class in Gtk 3, but doesn't in Gtk 4 and only looks to be used in the context of Gtk.TextView. Do we want it to be more widely available then?

@danirabbit
Copy link
Member

@wpkelso It looks like we did support it before and Adw supports it as well, so we might as well

@wpkelso wpkelso requested a review from danirabbit May 7, 2025 19:08
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small thing

@wpkelso wpkelso requested a review from danirabbit May 8, 2025 17:33
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Nice job

@danirabbit danirabbit merged commit 64156d3 into elementary:main May 9, 2025
4 checks passed
@wpkelso wpkelso deleted the styles/monospace branch May 9, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants