Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 1, 2025

Some of the files with existing headers were licensed as LGPL so that's what I did here. Let me know if that should be GPL instead

@danirabbit danirabbit requested a review from stsdc April 1, 2025 18:25
@lenemter
Copy link
Member

lenemter commented Apr 1, 2025

Shouldn't we use SPDX-FileCopyrightText before 'Copyright 2025 elementary, Inc. (https://elementary.io)'?

@danirabbit
Copy link
Member Author

Oops, yes you're right. Bad copy/paste. Should be fixed now

@stsdc
Copy link
Member

stsdc commented Apr 1, 2025

Some files have LGPL, because they're straight from elementary's projects. I left header files to respect original license.
Is there a need for header files if there is LICENSE file in a project root directory?
Also headers are LGPL and LICENSE file is GPL, isn't that a conflict?

@danirabbit
Copy link
Member Author

@stsdc okay changed those all to GPL instead of LGPL, except for the ones that were previously already licensed as LGPL.

It's not required but it is recommended. Especially when you have multiple licenses in a project, such as we do here were some files are LGPL. It just makes things more clear and easier for someone to respect the license if they re-use this code

@stsdc stsdc merged commit 7886780 into dev Apr 1, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/license-headers branch April 1, 2025 20:00
@stsdc stsdc added this to the Version 1.0.0 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants