Skip to content

Integrate Headerbar to MainWindow #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stsdc merged 5 commits into from
Apr 1, 2025
Merged

Integrate Headerbar to MainWindow #425

stsdc merged 5 commits into from
Apr 1, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 1, 2025 •
edited
Loading

HeaderBar is sealed in GTK4, so add it to MainWindow

  • Remove an extra grid
  • reduce public widgets to private set
  • initialize objects with properties
  • use child property in revealer

@danirabbit danirabbit requested a review from a team April 1, 2025 18:40
@danirabbit danirabbit changed the title Headerbar: rewrite in gobject style, code style, etc Integrate Headerbar to MainWindow Apr 1, 2025
@stsdc stsdc added this to the Version 1.0.0 milestone Apr 1, 2025
@stsdc stsdc enabled auto-merge (squash) April 1, 2025 22:12
@stsdc stsdc merged commit d4ff141 into dev Apr 1, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/headerbar-cleanup branch April 1, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stsdc stsdc stsdc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Version 8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @stsdc