Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 1, 2025

Fixes #390

Screenshot from 2025-04-01 19 14 51

Switches are used to toggle features on or off. Checkbuttons are used to include things as part of a list

@danirabbit danirabbit marked this pull request as ready for review April 1, 2025 19:42
@danirabbit danirabbit requested a review from a team April 1, 2025 19:42
@teamcons
Copy link

teamcons commented Apr 1, 2025

Width request 500 ?
I would picture something more in-line with similar apps, like terminal.
The update bar does not require this much space

have you thought about possibly wrapping the checkbox part in the same manner the notification indicator wraps notifications ? (im not sure of that widgets name) - this could reduce vertical usage, and avoid visual noise

@danirabbit
Copy link
Member Author

@teamcons I just kept the existing width request.

That section is in a revealer already, so if the switch is disabled, it will hide all the extra indicator options:

Screenshot from 2025-04-01 12 35 38

@stsdc
Copy link
Member

stsdc commented Apr 1, 2025

Would be nice to have it scrollable:

image

image

@stsdc
Copy link
Member

stsdc commented Apr 1, 2025

I have an idea for checkboxes overhaul. Just writing to not forget:
basically mimic Wingpanel by putting black stripe with icons. Checkboxes would be placed under every icon.

Or something like this, but with checkboxes:
image

@stsdc stsdc added this to the Version 1.0.0 milestone Apr 1, 2025
@danirabbit
Copy link
Member Author

@stsdc I tried to add a scrolled window, but it looks like it doesn't get used when you resize the window. At least this is only an X11 bug and on Wayland it doesn't clip popovers:

Screenshot from 2025-04-01 19 17 27

@stsdc stsdc merged commit a0b297a into dev Apr 3, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/prefs-singleview branch April 3, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preferences: Replace SettingsSidebar and SimpleSettingsPage

4 participants