Skip to content

Conversation

@stsdc
Copy link
Member

@stsdc stsdc commented Apr 14, 2025

This is an attempt at porting libpci to vapi and use it in Monitor to detect PCI devices.

Trying to make a basic example to work.

@stsdc stsdc mentioned this pull request Apr 14, 2025
@danirabbit

This comment was marked as outdated.

Copy link

@glm11-aoc glm11-aoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some notes on the code :-)

@stsdc stsdc requested a review from ryonakano May 10, 2025 09:01
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small tiny nitpicking, otherwise LGTM.

@stsdc stsdc requested a review from a team May 14, 2025 07:47
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but there is a nice-catch comment from Leo.

@stsdc stsdc requested review from lenemter and ryonakano May 14, 2025 12:10
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me!

image

@stsdc stsdc merged commit 7a75779 into main May 14, 2025
4 checks passed
@stsdc stsdc deleted the stsdc/libpci branch May 14, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce a proper GPU discovery mechanism

7 participants