-
-
Notifications
You must be signed in to change notification settings - Fork 48
Use libpci to retrieve some basic PCI data #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
glm11-aoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some notes on the code :-)
Co-authored-by: Ryo Nakano <[email protected]>
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small tiny nitpicking, otherwise LGTM.
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 but there is a nice-catch comment from Leo.
lenemter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This is an attempt at porting libpci to vapi and use it in Monitor to detect PCI devices.
Trying to make a basic example to work.