ProcessInfoView: Preventer → Granite.MessageDialog

[danirabbit]

Replaces the "preventer" stack-based width with Granite.MessageDialog

• Change Kill to Force Quit to avoid violent language
• Text buttons shouldn't also have text tooltips
• Only one of Suggested or Destructive should be used for a selection of buttons
• Make buttons homogeneous
• Use the extra room we have in Message Dialog to further explain options and their consequences. Use icons to re-enforce outcomes
• Use action names for button labels instead of ambiguous "yes" and "no"
• Use ellipsis to indicate that actions aren't triggered immediately but need further action somewhere else

[stsdc]

Agree on everything except the replacement "preventer" with a Granite.MessageDialog.
Do you consider MessageDialog a better UX?

[danirabbit]

@stsdc yes 100%. If the action is something that needs confirmation then messagedialog is the standard way to do that and it needs to have more explanation of why you're requesting to confirm

[wpkelso]

I'm inclined toward adding a toast or notification before merging, instead of leaving it to another request. For Shutdown, it's important that the user knows whether or not the request was successfully fulfilled, or if they need to think about Force Quitting instead.

[danirabbit]

This was already a leftover TODO from main. I'm not adding any functionality here. I'd prefer to leave that to a follow up since I didn't introduce that problem in this branch

[stsdc]

@danirabbit OK. But I would apply this change to gtk4-port branch.

[danirabbit]

@stsdc I would prefer to get it in first so we don't have to port the Preventer to Gtk4 and create a bunch of conflicts since you can't subclass Stack in GTK4 😅

[stsdc]

ah, ok. Didn't know about this limitation. I will properly review tomorrow and align gtk4 branch accordingly. Thanks @danirabbit!

[danirabbit]

@stsdc haha yeah that was my motivation is I was going to make a GTK4 prep branch for Preventer that doesn't subclass Stack and then I was like "Wait a minute, this should be messagedialog anyways"

[wpkelso]

Looks good to me for UX