Skip to content

ProcessInfoHeader: cleanup #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stsdc merged 3 commits into from
Jul 12, 2025
Merged

ProcessInfoHeader: cleanup #448

stsdc merged 3 commits into from
Jul 12, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 11, 2025 •
edited
Loading

Can be rebase merged.

  • Fix up code style. Initialize with properties. Prefer properties. Use Granite style constant, etc
  • Replace Gtk.Fixed with magic numbers with a Gtk.Overlay
  • Set gicon directly instead of converting it to a string

@stsdc stsdc merged commit dd574b2 into main Jul 12, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/processinfoheader-cleanups branch July 12, 2025 12:24
@stsdc stsdc mentioned this pull request Jul 18, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardo-lemos leonardo-lemos leonardo-lemos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danirabbit @leonardo-lemos @stsdc