Skip to content

Conversation

@danirabbit
Copy link
Member

  • GObject-style construction
  • Use properties instead of set functions
  • Don't expose internal widgets publicly
  • Use a vertical box instead of Gtk.Fixed
  • Use Granite style constants
  • Set mnemonic widget for screen reader

Styles:

  • Rewrite styles so they're all grouped under the toplevel node
  • Fix text color in dark mode
  • Use tnum feature so labels don't move around as their values change
  • remove redudant username-current style. This is the same as the default style

@danirabbit danirabbit requested a review from a team July 11, 2025 21:19
@stsdc stsdc force-pushed the danirabbit/roundylabel-cleanups branch from 2744082 to c01b8c6 Compare July 12, 2025 14:22
@stsdc
Copy link
Member

stsdc commented Jul 12, 2025

Sorry for merging 'main' here. It is better if you resolve the conflicts.

@danirabbit danirabbit requested a review from stsdc July 14, 2025 21:04
@danirabbit danirabbit requested a review from stsdc August 1, 2025 16:15
stsdc
stsdc previously requested changes Aug 8, 2025
public void set_text (string text) {
val.set_text (text);
class construct {
set_css_name ("roundy-label");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where, but we lost halign property. The default value should be Gtk.Align.START. Otherwise it fills the whole chart.
obraz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d058eab

@stsdc stsdc dismissed their stale review August 25, 2025 16:52

The fix for halign has been commited.

@stsdc stsdc merged commit e32b583 into main Aug 25, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/roundylabel-cleanups branch August 25, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants