Skip to content

MainWindow: cleanup #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stsdc merged 3 commits into from
Jul 16, 2025
Merged

MainWindow: cleanup #452

stsdc merged 3 commits into from
Jul 16, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 14, 2025

  • Reduce variable scope where possible. Make ProcessView private set
  • GObject-style construction
  • Code style. Prefer properties
  • Pack into a box. Grid can't have orientation in GTK4
  • It's cheaper to compare refs than strings in Gtk.Stack's visible child

@danirabbit danirabbit requested a review from a team July 14, 2025 21:21
@stsdc stsdc merged commit a59bf98 into main Jul 16, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/mainwindow-cleanups branch July 16, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stsdc stsdc stsdc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @stsdc