Skip to content

SystemCPUView: code style cleanup #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stsdc merged 2 commits into from
Sep 23, 2025
Merged

SystemCPUView: code style cleanup #460

stsdc merged 2 commits into from
Sep 23, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 23, 2025

GTK4 prep

  • Initialize properties with objects
  • explicit margins
  • Fix some broken whitespace
  • Don't abuse Gtk to stack objects on Z, use Overlay
  • Replace Grid with Box where appropriate
  • White space between different objects, after functions

@danirabbit danirabbit requested a review from a team September 23, 2025 17:12
stsdc
stsdc approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@stsdc stsdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Especially the Gtk.Overlay usage, looks nicer.

@stsdc stsdc merged commit 33f86db into main Sep 23, 2025
4 of 8 checks passed
@stsdc stsdc deleted the danirabbit/systemcpuview-cleanups branch September 23, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stsdc stsdc stsdc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @stsdc