Skip to content

ProcessView: reduce object access, build ui in construct #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 1 commit into from
Sep 30, 2025
Merged

ProcessView: reduce object access, build ui in construct #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions src/Views/ProcessView/ProcessView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,42 +4,39 @@
*/

public class Monitor.ProcessView : Gtk.Box {
public TreeViewModel treeview_model;
public CPUProcessTreeView process_tree_view;
public TreeViewModel treeview_model { get; private set; }
public CPUProcessTreeView process_tree_view { get; private set; }

public ProcessInfoView process_info_view;
private ProcessInfoView process_info_view;

construct {
process_info_view = new ProcessInfoView ();

// hide on startup
process_info_view.no_show_all = true;
}

public ProcessView () {
treeview_model = new TreeViewModel ();

process_tree_view = new CPUProcessTreeView (treeview_model);
process_tree_view.process_selected.connect ((process) => on_process_selected (process));

// making tree view scrollable
var process_tree_view_scrolled = new Gtk.ScrolledWindow (null, null);
process_tree_view_scrolled.add (process_tree_view);
var process_tree_view_scrolled = new Gtk.ScrolledWindow (null, null) {
child = process_tree_view
};

var paned = new Gtk.Paned (Gtk.Orientation.HORIZONTAL);
process_info_view = new ProcessInfoView () {
// hide on startup
no_show_all = true
};

var paned = new Gtk.Paned (HORIZONTAL) {
hexpand = true
};
paned.position = paned.max_position;
paned.pack1 (process_tree_view_scrolled, true, false);
paned.pack2 (process_info_view, false, false);
// paned.set_min_position (200);
paned.set_position (paned.max_position);
paned.set_hexpand (true);

add (paned);
}

public void on_process_selected (Process process) {
process_info_view.process = process;
process_info_view.no_show_all = false;
// process_info_view.show_all ();
}

public void update () {
Expand All @@ -54,5 +51,4 @@ public class Monitor.ProcessView : Gtk.Box {
});

}

}