Skip to content

Add support for notification spec 1.3 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Oct 3, 2025
Merged

Add support for notification spec 1.3 #259

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89b2933
Add support for notification spec 1.3
lenemter Oct 3, 2025
163681c
Use phone-* sounds
lenemter Oct 3, 2025
8875775
Use phone-hangup sound
lenemter Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/DBus.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public class Notifications.Server : Object {
name = "io.elementary.notifications";
vendor = "elementaryOS";
version = "0.1";
spec_version = "1.2";
spec_version = "1.3";
}

public new uint32 notify (
Expand Down Expand Up @@ -237,6 +237,13 @@ public class Notifications.Server : Object {
unowned string sound;

switch (category) {
case "call":
case "call.ended":
case "call.incoming":
case "call.unanswered":
// We probably should use "phone-incoming-call" but it sounds awful in freedesktop theme
sound = "dialog-information";
break;
case "device.added":
sound = "device-added";
break;
Expand Down