Skip to content

Themes: Make color09 different from bg #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 3 commits into from
Feb 6, 2026
Merged

Themes: Make color09 different from bg #985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fcfe1
brblack and bg shouldn't be the same
wpkelso Feb 5, 2026
7275fb3
base1 has better contrast than black
wpkelso Feb 6, 2026
8759552
Merge branch 'main' into wpkelso/custom-theme
jeremypw Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/io.elementary.terminal.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
<description>The shape of the cursor of the terminal.</description>
</key>
<key name="palette" type="s">
<default>"#073642:#dc322f:#859900:#b58900:#268bd2:#d33682:#2aa198:#eee8d5:#002b36:#dc322f:#586e75:#657b83:#839496:#6c71c4:#93a1a1:#fdf6e3"</default>
<default>"#073642:#dc322f:#859900:#b58900:#268bd2:#d33682:#2aa198:#eee8d5:#073642:#dc322f:#586e75:#657b83:#839496:#6c71c4:#93a1a1:#fdf6e3"</default>
Copy link
Copy Markdown
Member

@danirabbit danirabbit Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is right? From reading the bug description it sounds like we actually need this to be much brighter. In the dark elementary theme for example this is #5e5c64 (which I'm not sure if we need to check that for contrast). It looks like maybe the better color in the solarized palette would be like base0 or base1

Screenshot from 2026-02-05 14 22 25 Screenshot from 2026-02-05 14 22 38

Copy link
Copy Markdown
Member Author

@wpkelso wpkelso Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I made the same mistake as was originally done and used a literal reading of the Solarized spec. base1 probably makes the most sense to use, as we're not going to avoid conflicts no matter what we choose

<summary>Palette of the terminal.</summary>
<description>Defines the colors of various things in the terminal.</description>
</key>
Expand Down