Skip to content

Internal: Revert changes to quicklinks [TMZ-923] #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hein-obox merged 4 commits into from
Sep 11, 2025
Merged

Internal: Revert changes to quicklinks [TMZ-923] #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
859da58
Revert quicklinks
hein-obox Sep 9, 2025
de15290
Update site settings link
hein-obox Sep 10, 2025
c862fe3
Remove conditional test inside daily matrix
hein-obox Sep 10, 2025
69f8e9d
Clean up code
hein-obox Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions modules/admin-home/rest/admin-config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ private function get_elementor_editor_url( ?int $page_id, string $active_tab ):
'post' => $page_id,
'action' => 'elementor',
'active-tab' => $active_tab,
'active-document' => $active_kit_id,
],
admin_url( 'post.php' )
);
Expand Down Expand Up @@ -285,18 +284,18 @@ public function get_quicklinks( $config, ?int $elementor_page_id = null ): array
$config['quickLinks'] = [
'site_name' => [
'title' => __( 'Site Name', 'hello-elementor' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity', null, [ 'autofocus[section]' => 'title_tagline' ] ),
'icon' => 'TextIcon',

],
'site_logo' => [
'title' => __( 'Site Logo', 'hello-elementor' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity', null, [ 'autofocus[section]' => 'title_tagline' ] ),
'icon' => 'PhotoIcon',
],
'site_favicon' => [
'title' => __( 'Site Favicon', 'hello-elementor' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity' ),
'link' => $this->get_open_homepage_with_tab( $elementor_page_id, 'settings-site-identity', null, [ 'autofocus[section]' => 'title_tagline' ] ),
'icon' => 'AppsIcon',
],
];
Expand Down
5 changes: 0 additions & 5 deletions tests/playwright/tests/admin/hello-theme-admin-home.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@
const linkElement = page.locator( `h6:has-text("${ linkTest.linkText }") a` );
await expect( linkElement ).toBeVisible();

if ( !! process.env.DAILY_MATRIX_WORKFLOW ) {
// Skip this test in Daily Matrix workflow due to artifact deployment timing issues
continue;
}

await Promise.all( [
page.waitForURL( linkTest.expectedUrlPattern ),
linkElement.click(),
Expand All @@ -75,7 +70,7 @@

expect( page.url() ).toMatch( linkTest.expectedUrlPattern );

await page.waitForSelector( '#elementor-kit-panel' );

Check failure on line 73 in tests/playwright/tests/admin/hello-theme-admin-home.test.ts

View workflow job for this annotation

GitHub Actions / playwright-tests

tests/playwright/tests/admin/hello-theme-admin-home.test.ts:33:6 › Hello Theme Admin Home Page › should navigate to correct pages from Quick Links 

  1) tests/playwright/tests/admin/hello-theme-admin-home.test.ts:33:6 › Hello Theme Admin Home Page › should navigate to correct pages from Quick Links 
    TimeoutError: page.waitForSelector: Timeout 30000ms exceeded.
    Call log:
      - waiting for locator('#elementor-kit-panel') to be visible


      71 | 			expect( page.url() ).toMatch( linkTest.expectedUrlPattern );
      72 |
    > 73 | 			await page.waitForSelector( '#elementor-kit-panel' );
         | 			           ^
      74 | 			const location = page.locator( linkTest.expectedPageSection );
      75 | 			await expect( location ).toBeVisible();
      76 | 		}
        at /home/runner/work/hello-theme/hello-theme/tests/playwright/tests/admin/hello-theme-admin-home.test.ts:73:15
const location = page.locator( linkTest.expectedPageSection );
await expect( location ).toBeVisible();
}
Expand Down
Loading