Skip to content

Conversation

@nicoladj77
Copy link
Contributor

@nicoladj77 nicoladj77 commented Sep 16, 2025

✨ PR Description

Purpose: Refactor PLG (Product Lead Generation) conversion banner to display only on specific admin pages with targeted placement.
Main changes:

  • Added whitelist of admin pages with custom CSS selectors for banner placement
  • Implemented conditional rendering logic with before/after positioning options
  • Added constants for script handles, nonce actions, and user meta keys
  • Updated JS implementation to use page-specific selectors

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements selective display of a Product-Led Growth (PLG) conversion banner on specific WordPress admin pages instead of showing it globally. The changes introduce a page-specific configuration system that determines where and how the banner should be displayed.

  • Adds a comprehensive list of allowed admin pages with their corresponding CSS selectors
  • Modifies banner activation logic to return page configuration data instead of a boolean
  • Updates JavaScript to use dynamic selectors for banner positioning

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
phpcs.xml Updates PHP CodeSniffer property name for WordPress deprecated functions rule
modules/admin-home/components/conversion-banner.php Implements page-specific banner display logic with allowed pages configuration
modules/admin-home/assets/js/hello-elementor-conversion-banner.js Updates banner positioning to use dynamic selectors from configuration
.vscode/settings.json Adds VS Code workspace settings for PHP CodeSniffer integration
.buildignore Excludes VS Code settings from build output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nicoladj77 nicoladj77 merged commit 6ab0b47 into main Sep 19, 2025
60 of 65 checks passed
@nicoladj77 nicoladj77 deleted the TMZ-919-plg-refactoring branch September 19, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants