-
Notifications
You must be signed in to change notification settings - Fork 246
Tweak: Show PLG only on selected pages [TMZ-919] #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements selective display of a Product-Led Growth (PLG) conversion banner on specific WordPress admin pages instead of showing it globally. The changes introduce a page-specific configuration system that determines where and how the banner should be displayed.
- Adds a comprehensive list of allowed admin pages with their corresponding CSS selectors
- Modifies banner activation logic to return page configuration data instead of a boolean
- Updates JavaScript to use dynamic selectors for banner positioning
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| phpcs.xml | Updates PHP CodeSniffer property name for WordPress deprecated functions rule |
| modules/admin-home/components/conversion-banner.php | Implements page-specific banner display logic with allowed pages configuration |
| modules/admin-home/assets/js/hello-elementor-conversion-banner.js | Updates banner positioning to use dynamic selectors from configuration |
| .vscode/settings.json | Adds VS Code workspace settings for PHP CodeSniffer integration |
| .buildignore | Excludes VS Code settings from build output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✨ PR Description
Purpose: Refactor PLG (Product Lead Generation) conversion banner to display only on specific admin pages with targeted placement.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀