[APP-721] Render widget and global settings #124
Conversation
| wp_localize_script( | ||
| 'ea11y-widget', | ||
| 'ea11yWidgetData', | ||
| [ | ||
| 'iconSettings' => wp_json_encode( get_option( 'ea11y_widget_icon_settings' ) ), | ||
| 'menuSettings' => wp_json_encode( get_option( 'ea11y_widget_menu_settings' ) ), | ||
| 'wpRestNonce' => wp_create_nonce( 'wp_rest' ) | ||
| ] | ||
| ); |
There was a problem hiding this comment.
Let's stick to the agreements we've had.
The widget expects an object named ea11yWidget with the field preview: true inside. It also doesn't need wpRestNonce, not sure if you keep it for some other piece of logic, but please move it elsewhere.
pkniazevych
left a comment
pkniazevych
left a comment
There was a problem hiding this comment.
Please, check the comment.
classes/services/client.php
Outdated
| * @return string | ||
| */ | ||
| private static function webhook_endpoint(): string { | ||
| $blog_id = get_current_blog_id(); |
There was a problem hiding this comment.
| $blog_id = get_current_blog_id(); | |
| $blog_id = get_current_blog_id(); |
classes/services/client.php
Outdated
| /** | ||
| * product/widget endpoint returns javascript hence we | ||
| * escape decoding for the data received in body from | ||
| * this endpoint. | ||
| */ | ||
| if ( ! strpos( $endpoint, 'widget' ) ) { | ||
| $body = json_decode( $body ); | ||
| } |
There was a problem hiding this comment.
why do we need this? we will never call the widget from the service client directly
| public function __construct() { | ||
| add_action( 'wp_enqueue_scripts', [ $this, 'enqueue_accessibility_widget' ] ); | ||
| } |
There was a problem hiding this comment.
this should be enqueue only if connected
There was a problem hiding this comment.
@bainternet Should there be a check for plan data as well? If the pan data is not available, then the widget should not load.
There was a problem hiding this comment.
Yes also the pr is not fixed in both comments
modules/widget/module.php
Outdated
| return; | ||
| } | ||
|
|
||
| if ( empty ( Settings::PLAN_DATA ) && ! isset( $plan_data->public_api_key ) ) { |
There was a problem hiding this comment.
this must be wrong empty ( Settings::PLAN_DATA )
| return; | ||
| } | ||
|
|
||
| $plan_data = Settings::get( Settings::PLAN_DATA ); |
There was a problem hiding this comment.
and this should probably be above it
…nirbhayel/one-click-accessibility into feature/APP-721-pass-settings-to-widget
No description provided.