Skip to content

[APP-1050] Fix exact position options #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nirbhayel wants to merge 1 commit into from
Closed

[APP-1050] Fix exact position options #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 45 additions & 14 deletions modules/settings/assets/js/components/position-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,29 @@ import { __ } from '@wordpress/i18n';
const units = ['PX', 'REM', 'EM'];

const horizontalOptions = [
{ value: 'left', label: __('To the left', 'pojo-accessibility') },
{ value: 'right', label: __('To the right', 'pojo-accessibility') },
{
value: 'left',
label: __('To the left', 'pojo-accessibility'),
hideFor: ['top-left', 'bottom-left', 'center-left'],
},
{
value: 'right',
label: __('To the right', 'pojo-accessibility'),
hideFor: ['top-right', 'bottom-right', 'center-right'],
},
];

const verticalOptions = [
{ value: 'top', label: __('Higher', 'pojo-accessibility') },
{ value: 'bottom', label: __('Lower', 'pojo-accessibility') },
{
value: 'top',
label: __('Higher', 'pojo-accessibility'),
hideFor: ['top-left', 'top-center', 'top-right'],
},
{
value: 'bottom',
label: __('Lower', 'pojo-accessibility'),
hideFor: ['bottom-left', 'bottom-center', 'bottom-right'],
},
];

const StyledContainer = styled(Box)`
Expand Down Expand Up @@ -185,6 +201,11 @@ const PositionControl = ({ type, disabled, mode }) => {
onChange={handlePositionDirection}
disabled={disabled}
value={iconPosition[mode]?.exactPosition?.[type].direction}
defaultValue={
iconPosition[mode]?.exactPosition[type]?.direction === 'horizontal'
? 'bottom-left'
: 'higher'
}
MenuProps={{
MenuListProps: {
sx: {
Expand All @@ -202,16 +223,26 @@ const PositionControl = ({ type, disabled, mode }) => {
}}
>
{type === 'horizontal'
? horizontalOptions.map((option) => (
<MenuItem key={option.value} value={option.value}>
{option.label}
</MenuItem>
))
: verticalOptions.map((option) => (
<MenuItem key={option.value} value={option.value}>
{option.label}
</MenuItem>
))}
? horizontalOptions.map((option) => {
if (option?.hideFor?.includes(iconPosition[mode]?.position)) {
return null;
}
return (
<MenuItem key={option.value} value={option.value}>
{option.label}
</MenuItem>
);
})
: verticalOptions.map((option) => {
if (option?.hideFor?.includes(iconPosition[mode]?.position)) {
return null;
}
return (
<MenuItem key={option.value} value={option.value}>
{option.label}
</MenuItem>
);
})}
</Select>
</StyledContainer>
);
Expand Down
Loading