Skip to content

[APP-1727] Update column actions#343

Merged
nirbhayel merged 7 commits intodevelopfrom
update/app-1727-update-post-column
Aug 5, 2025
Merged

[APP-1727] Update column actions#343
nirbhayel merged 7 commits intodevelopfrom
update/app-1727-update-post-column

Conversation

@nirbhayel
Copy link
Contributor

@nirbhayel nirbhayel commented Jul 18, 2025

✨ PR Description

Purpose: Update accessibility column UI in admin post lists with responsive behavior and improved visual presentation.
Main changes:

  • Replaced percentage progress bar with simple action buttons that adapt to column width
  • Added CSS tooltips for narrow column layouts with responsive behavior
  • Implemented JavaScript for dynamic button text and column responsiveness

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

gitstream-cm[bot]

This comment was marked as resolved.

$content = '<img src="' . esc_url( EA11Y_ASSETS_URL . 'images/check-icon.svg' ) . '" alt="' . esc_attr__( 'All accessibility issues resolved', 'pojo-accessibility' ) . '" style="width:24px; height:24px;" />';
} else {
if ( $has_scan_data ) {
$issues_left = $violation - $resolved;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this comment

Copy link
Contributor

@pkniazevych pkniazevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider a tiny improvement suggested by the bot

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR continues the refactoring from progress bars to responsive action buttons. While the changes maintain the previous functionality, there are some performance and initialization concerns that should be addressed.

1 issues detected:

🚀 Performance - Multiple initialization calls create unnecessary performance overhead and potential duplicate registrations.

Details: The setupEnhancements method is called multiple times during initialization - once in DOMContentLoaded event, immediately if document is ready, and again after a 500ms timeout. This creates unnecessary processing overhead and could cause duplicate event listeners or observer registrations.
File: modules/scanner/assets/js/list-column.js

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@nirbhayel nirbhayel merged commit 0157ecb into develop Aug 5, 2025
91 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants