[APP-1741][APP-1742][APP-1743] add components, calc contrast ratio, a…#346
[APP-1741][APP-1742][APP-1743] add components, calc contrast ratio, a…#346
Conversation
…dd logic for lightness
![gitstream-cm[bot]](https://avatars.githubusercontent.com/in/230441?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-set.js Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gitstream-cm
bot
added
🚨 1 Unresolved Thread(s)
and removed
🚨 1 Unresolved Thread(s)
labels
| sx={{ width: '150px' }} | ||
| onChange={onChangeColor} | ||
| /> | ||
| <SunIcon /> |
| }} | ||
| /> | ||
| <StyledColorDisplay sx={{ background: color }} /> | ||
| <IconButton onClick={resetColor} size="tiny"> |
There was a problem hiding this comment.
Please add an aria-label
| {title} | ||
| </Typography> | ||
| <StyledColorSet> | ||
| <SunOffIcon /> |
| </Typography> | ||
| <StyledColorSet> | ||
| <SunOffIcon /> | ||
| <Slider |
There was a problem hiding this comment.
It should have a label, bc a screen reader only announces a value with no other context.
|
|
||
| return ( | ||
| <Box> | ||
| <Typography variant="body2" as="h5"> |
There was a problem hiding this comment.
I'm not sure it can be considered as a title. To me as="p" seems more appropriate.
Ideally, it should be a , but I don't see any form elements inside the slider component
| return ( | ||
| <StyledBox> | ||
| <Divider /> | ||
| <Typography variant="body2" as="h4"> |
There was a problem hiding this comment.
I'm not sure it can be considered as a title. To me as="p" seems more appropriate.
gitstream-cm
bot
added
🚨 5 Unresolved Thread(s)
🚨 6 Unresolved Thread(s)
and removed
🚨 4 Unresolved Thread(s)
🚨 5 Unresolved Thread(s)
labels
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gitstream-cm
bot
added
🚨 6 Unresolved Thread(s)
and removed
🚨 8 Unresolved Thread(s)
labels
…-set.js Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
…-set.js Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gitstream-cm
bot
added
🚨 6 Unresolved Thread(s)
and removed
🚨 6 Unresolved Thread(s)
🚨 7 Unresolved Thread(s)
labels
Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gitstream-cm
bot
added
🚨 8 Unresolved Thread(s)
and removed
🚨 6 Unresolved Thread(s)
labels
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gitstream-cm
bot
added
🚨 7 Unresolved Thread(s)
and removed
🚨 8 Unresolved Thread(s)
labels
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
2 participants
…dd logic for lightness
✨ PR Description
Purpose: Add color contrast components for accessibility assessment and implement color adjustment functionality in the accessibility scanner.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀