Fix: Use different field to check if Elementor Pro is enabled [APP-2198] #500
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bainternet
approved these changes
Jan 22, 2026
bainternet
reviewed
Jan 22, 2026
| <script> | ||
| const registerAllyAction = () => { | ||
| if ( ! window?.elementorAppConfig?.hasPro || ! window?.elementorFrontend?.utils?.urlActions ) { | ||
| if ( ! window?.ElementorProFrontendConfig || ! window?.elementorFrontend?.utils?.urlActions ) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ( ! window?.ElementorProFrontendConfig || ! window?.elementorFrontend?.utils?.urlActions ) { | |
| if ( ! window?.ElementorFrontendConfig || ! window?.elementorFrontend?.utils?.urlActions ) { |
Pro is not a requirement, but this is not tested
Contributor
Author
There was a problem hiding this comment.
It's not a requirement, but why would we need this code if there is no Pro?
I found the safest object in the codebase, it's defined by PHP and should be always there.
Contributor
There was a problem hiding this comment.
because we want it for core users and not just pro
Contributor
Author
There was a problem hiding this comment.
Discussed in Slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR Description
Purpose: Fix Elementor Pro detection logic in dynamic tag handler to use frontend-specific config instead of app config for accurate plugin status checking.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how