Split the project into a JVM and Android lib #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeffreydelooff
left a comment
jeffreydelooff
left a comment
There was a problem hiding this comment.
Are the launcher icons needed?
| override fun putFloat(key: String?, value: Float): SharedPreferences.Editor = put(key, value) | ||
|
|
||
| override fun putString(key: String?, value: String?): SharedPreferences.Editor = put(key, value) | ||
| override fun putString(key: String?, value: String?): SharedPreferences.Editor = put(key, value!!) |
Collaborator
There was a problem hiding this comment.
Can't value be non null then? Otherwise don't force unwrap?
Contributor
Author
There was a problem hiding this comment.
At the moment the lib anticipates a value to be non-null whenever it got requested. When requesting you always should check wether there is a value first.
I got some feedback on the and I would like to refactor to 'Maybe'. But that would be a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.