feat(#96): use code suggestions for GitLab #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/lgtm review |
sdn4z
approved these changes
Aug 29, 2025
jbozanowski
reviewed
Aug 29, 2025
|
|
||
| @model_validator(mode="after") | ||
| def change_direction_of_zero(self) -> Self: | ||
| # GitLab freaks out if the offset is 0 and the direction is +. We change it to -. |
Collaborator
There was a problem hiding this comment.
I feel a distant echo of a math teacher screaming somewhere :D
Collaborator
Author
There was a problem hiding this comment.
Your doctors math teachers hate this one trick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature where in GitLab lgtm-ai will start using code suggestions instead of just markdown comments.
The LLM can choose whether it wants to do that, through a flag
ready_for_replacement.Review quality should not be affected, since it is the summarizing agent that creates the suggestion: the prompt of the reviewer is unchanged.
I tested it manually in one private GitLab repository, and it seemed to work pretty well. I am sure issues may arise in the future, but it is hard for me to predict them, so maybe better to ship this!
closes #96