feat: add -v option and improve logging
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdn4z
force-pushed
the
logging
branch
3 times, most recently
from
1c28085 to
84a04f9
Compare
Collaborator
Author
|
/lgtm review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🦉 lgtm Review
Score: Needs a Lot of Work 🚨
🔍 Summary
This PR makes some nice improvements by adding a -v flag for verbose output and refactoring the configuration. The centralization of constants and added logging are also welcome changes.
However, there are a few significant issues that need to be resolved before this can be merged. The main concerns are regressions in error handling and test coverage:
- Error Handling: The application can now crash if Sentry fails to initialize or if an invalid
LOG_LEVELis set in the environment. We should restore the previous robust error handling. - Test Coverage: Key assertions that verified logging output have been removed from the tests. For a PR that changes logging, it's essential to maintain or increase this test coverage to ensure everything works as expected.
Please address the comments below to fix these regressions. Once these are resolved, the PR will be in good shape.
More information
- Id:
d3094796d8f5434eab07222a76fdff31 - Model:
gemini-2.5-pro - Created at:
2025-11-06T11:30:38.184457+00:00
Usage summary
- Request count:
2 - Request tokens:
105,719 - Response tokens:
16,603 - Total tokens:
122,322
See the 📚 lgtm-ai repository for more information about lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now manage verbosity via a
-vflag in the cli.There's been also a minor refactor, that deletes de Settings class while keeping the same functionality, and some other minor changes.