feat: fail-fast in case of missing scanners #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scastlara
commented
Dec 6, 2024
|
|
||
| ```sh | ||
| sheriff patrol --gitlab-groups your-namespace-or-group --report-gitlab-issue | ||
| sheriff patrol --url gitlab://your-namespace-or-group --report-to-issue |
Collaborator
Author
There was a problem hiding this comment.
Unrelated but was missing from the previous PR. I know we still lack more docs about this whole new interface, but might as well update this now.
sacha-c
reviewed
Dec 9, 2024
scastlara
force-pushed
the
checkinstall
branch
from
c23c6d6 to
0677e6c
Compare
sacha-c
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is annoying that if you are missing
osv-scannerand scan a big group, you realize after the whole goroutine fiesta has started and you have to ctrl+c.I think this is better UX.
If in the future we have more scanners (#15) we can decide then if there are optional scanners, if these will be warnings, or if we will skip them.