Configure cli app and project level config in a config package #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacha-c
changed the title
sacha-c
changed the title
sacha-c
force-pushed
the
config-toml-refactor
branch
from
337f52e to
5b4886d
Compare
sacha-c
changed the title
scastlara
approved these changes
Dec 16, 2024
Collaborator
scastlara
left a comment
scastlara
left a comment
There was a problem hiding this comment.
Nice! I really like the separation now between patrol/project-level!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial refactor of where our app configurations live, to make pave the way for #32
Here I am:
configpackageconfigpackageI have split the changes into two separate commits so git will know what are file renamings & what are actual changes.
This will make it easier to manage configuration separately from the CLI package so we can fully use TOML as we wish.
Please take a look at this PR which is stacked on top of this one (link incoming), before accepting these changes. I made it a separate PR to clearly separate these changes