Skip to content

fix: make 128 no packages found not return an error #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scastlara merged 2 commits into from
Sep 22, 2025
Merged

fix: make 128 no packages found not return an error #67

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bafa82
fix: make 128 no packages found not return an error
scastlara Sep 22, 2025
537c77d
fix: remove custom type for codes
scastlara Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/scanner/osv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,18 @@ import (
)

type osvReferenceKind string
type osvReturnCode int

const (
OsvCommandName = "osv-scanner"
AdvisoryKind osvReferenceKind = "ADVISORY"
WebKind osvReferenceKind = "WEB"
PackageKind osvReferenceKind = "PACKAGE"
osvTimeout = 5 * time.Minute
// https://google.github.io/osv-scanner/output/#return-codes
osvReturnCodeSuccess osvReturnCode = 0
osvReturnCodeVulnsFound osvReturnCode = 1
osvReturnCodeNoPackages osvReturnCode = 128
)

type osvSource struct {
Expand Down Expand Up @@ -116,10 +121,13 @@ func (s *osvScanner) Scan(dir string) (*OsvReport, error) {
)

//Handle exit codes according to https://google.github.io/osv-scanner/output/#return-codes
if cmdOut.ExitCode == 0 && err == nil {
if cmdOut.ExitCode == int(osvReturnCodeSuccess) && err == nil {
// Successful run of osv-scanner, no report because no vulnerabilities found
log.Debug().Int("exitCode", cmdOut.ExitCode).Msg("osv-scanner did not find vulnerabilities")
return nil, nil
} else if cmdOut.ExitCode == int(osvReturnCodeNoPackages) {
log.Warn().Int("exitCode", cmdOut.ExitCode).Msg("osv-scanner did not find any packages to scan")
return nil, nil
} else if cmdOut.ExitCode > 1 || cmdOut.ExitCode == -1 {
// Failed to run osv-scanner at all, or it returned an error
log.Debug().Int("exitCode", cmdOut.ExitCode).Msg("osv-scanner failed to run")
Expand Down
Loading