refactor: Tweak thresholds #339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
sdn4z
force-pushed
the
tweak-thresholds
branch
from
47cfa84 to
2ed7a76
Compare
Collaborator
|
I am worried about a game of whac-a-mole here tweaking threshodls. How can we find out what are the best thresholds? |
Collaborator
|
nit: this isn't really a refactor, since it affects the functionality (hopefully better predictions) |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting too much noise when parsing
yarn.lockandpackage-lock.jsonfiles. The output is still not as clean as when we're parsing Python lock files though.I've increased the cutoff value to 10, as it produces less noise, and also changed the default selector_method to
first-letteras it's more performant and it as well returns less noise.closes #97
BREAKING CHANGE