ci: Trigger release notes job after publishing has succeeded #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdn4z
force-pushed
the
release-after-publish
branch
from
3a96094 to
90e8155
Compare
sdn4z
force-pushed
the
release-after-publish
branch
from
90e8155 to
5c17ad5
Compare
sdn4z
force-pushed
the
release-after-publish
branch
from
5c17ad5 to
fd87311
Compare
sdn4z
commented
Feb 7, 2025
| labels: ${{ steps.meta.outputs.labels }} | ||
| release_notes: | ||
| runs-on: ubuntu-latest | ||
| needs: push_to_docker_hub |
Collaborator
Author
There was a problem hiding this comment.
This is the important addition, now it needs push_to_docker_hub before running
scastlara
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes are created at the moment we publish tags. However, the fact that we could publish them does not mean that the
bump_versionjob was successful, like in this case, due to a misconfiguration of the rulesets.An easy way to solve the issue above would be: 1)fix the rulesets 2) delete tags 3) rerun
bump_versionjob. That's not currently possible, because in order to delete the tags we would need to first delete the release notes, and even if we did this, the job that publishes the release notes will be called twice.This PR ensures that we only publish the release notes if all the other jobs have succeeded, to avoid unexpected consequences.