Skip to content

Conversation

@sdn4z
Copy link
Collaborator

@sdn4z sdn4z commented Feb 7, 2025

No description provided.

@scastlara
Copy link
Collaborator

Out of scope, but for tools like these, you usually wanna test them in the lowest version supported, and the highest version supported. For instance: https://github.com/scastlara/minineedle/blob/master/.github/workflows/tests.yml#L12

@sdn4z
Copy link
Collaborator Author

sdn4z commented Feb 7, 2025

Out of scope, but for tools like these, you usually wanna test them in the lowest version supported, and the highest version supported. For instance: https://github.com/scastlara/minineedle/blob/master/.github/workflows/tests.yml#L12

something like this https://github.com/elementsinteractive/twyn/blob/main/.github/workflows/test.yml#L17 😂

@sdn4z sdn4z merged commit dbf8551 into elementsinteractive:main Feb 7, 2025
8 checks passed
@sdn4z sdn4z deleted the python313 branch February 7, 2025 14:02
@scastlara
Copy link
Collaborator

Out of scope, but for tools like these, you usually wanna test them in the lowest version supported, and the highest version supported. For instance: https://github.com/scastlara/minineedle/blob/master/.github/workflows/tests.yml#L12

something like this https://github.com/elementsinteractive/twyn/blob/main/.github/workflows/test.yml#L17 😂

😆 exactly.

But then, we were already supporting python 3.13! 🤔

@sdn4z
Copy link
Collaborator Author

sdn4z commented Feb 7, 2025

Out of scope, but for tools like these, you usually wanna test them in the lowest version supported, and the highest version supported. For instance: https://github.com/scastlara/minineedle/blob/master/.github/workflows/tests.yml#L12

something like this https://github.com/elementsinteractive/twyn/blob/main/.github/workflows/test.yml#L17 😂

😆 exactly.

But then, we were already supporting python 3.13! 🤔

Yes! seems we only updated the test action though. Anyways, we now have it everywhere 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants