fix: change client_tool_result.result from Map to String#37
Merged
shiragannavar merged 1 commit intomainfrom Dec 16, 2025
Merged
fix: change client_tool_result.result from Map to String#37shiragannavar merged 1 commit intomainfrom
shiragannavar merged 1 commit intomainfrom
Conversation
The backend expects client_tool_result.result as a string, not a JSON object. This was causing 'policy violation' errors when client tools returned results. Changes: - ConversationEventParser.kt: Change ClientToolResult.result type from Map<String, Any> to String - ConversationEventHandler.kt: Send result as string directly, not wrapped in a map - ConversationSession.kt: Update interface signature for sendToolResult() - ConversationSessionImpl.kt: Update implementation signature - DynamicClientToolTest.kt: Update tests to use string results - README.md: Update documentation examples Note: Users can still send complex data by serializing to JSON string (e.g., Gson().toJson(myObject)).
PaulAsjes
approved these changes
Dec 16, 2025
|
|
||
| /** | ||
| * Tool result event | ||
| * Note: result must be a String (plain text or JSON string), not a Map/Object. |
Collaborator
There was a problem hiding this comment.
Let's remove this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend expects client_tool_result.result as a string, not a JSON object. This was causing 'policy violation' errors when client tools returned results.
Changes:
Note: Users can still send complex data by serializing to JSON string (e.g., Gson().toJson(myObject)).