refactor: make Contract generic for Compiler and add metadata to CompilerOutput #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
changed the title
nbaztec
approved these changes
Nov 18, 2024
| impl<T: ArtifactOutput + Default> TempProject<MultiCompiler, T> { | ||
| impl< | ||
| T: ArtifactOutput<CompilerContract = <MultiCompiler as Compiler>::CompilerContract> + Default, | ||
| > TempProject<MultiCompiler, T> |
There was a problem hiding this comment.
Perhaps we could think about a type alias for this.
Owner
Author
There was a problem hiding this comment.
Yes it might make sense, want to see what foundry team says about the abstraction first because they probably have their own convention on how to handle types and names
Co-authored-by: Nisheeth Barthwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the compiler abstraction has two couplings that force foundry-zksync to implement it's own fork of compilers:
Contractis specific tosolc/EVM contracts. Era VM contracts, while requiring different fields, still could use most of the functionality of thecompilerspipeline.CompilerOutputhassolcspecific fields.zksolccompilation has relevant information that is useful to have later on, for example when storingBuildInfoThis PR implements changes to address this. If implemented, it would allow
foundry-zksyncto get rid of all overrides and only maintain ZKsync specific data structures/trait implementations. See sample PR. Changes include:Compilergeneric overContract.metadatafield toCompilerOutputin order to add arbitrary data to compilation output.