Skip to content

Comments

Dnssec-aware functionality#26

Open
andreavivaldi wants to merge 12 commits intoelgs:masterfrom
andreavivaldi:dnssec
Open

Dnssec-aware functionality#26
andreavivaldi wants to merge 12 commits intoelgs:masterfrom
andreavivaldi:dnssec

Conversation

@andreavivaldi
Copy link

No description provided.

@elgs
Copy link
Owner

elgs commented May 31, 2017

Thank you! I need some time to understand the changes in removeComments and flatten.

@andreavivaldi
Copy link
Author

No problem. Take your time. Let me know if you need some explanation... I'm sorry that there is no comment in the code.
Also I invite you to run some other tests.
Feel free to report me any (probable) error or misunderstanding of the flow.

I can explain right now why I've changed the flatten function:I've rewritten it not to delete all the comments on DNSKEY RR, because they contains the Key ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants