Skip to content

Mark form finishers as approval/dismissal dependant via form editor#354

Open
alexanderkuenzl wants to merge 2 commits intoeliashaeussler:mainfrom
alexanderkuenzl:variant-formeditor
Open

Mark form finishers as approval/dismissal dependant via form editor#354
alexanderkuenzl wants to merge 2 commits intoeliashaeussler:mainfrom
alexanderkuenzl:variant-formeditor

Conversation

@alexanderkuenzl
Copy link

Adresses #353

This branch contains consent options for common finishers: Users can mark a finisher as consent dependant, the form definition gets saved with variants, and the finishers get recombined into one list when reopeneing the form in editor.

[WIP] I have tested this feature with TYPO3 13.4, I can do more tests/documentation.

Thank you for your work!

alexanderkunzl added 2 commits March 19, 2025 22:12
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13956821170

Details

  • 8 of 101 (7.92%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.2%) to 83.781%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Hooks/ModifyFormVariantsHook.php 0 5 0.0%
Classes/Event/Listener/AfterFormDefinitionLoadedEventListener.php 0 9 0.0%
Classes/Middleware/FormVariantMiddleware.php 8 22 36.36%
Classes/Domain/Variants/ConsentVariantManager.php 0 65 0.0%
Totals Coverage Status
Change from base Build 13956814363: -9.2%
Covered Lines: 780
Relevant Lines: 931

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants