Skip to content

feat: gradle module metadata#1506

Merged
Sam Gammon (sgammon) merged 16 commits intomainfrom
chore/lib-publishing-fixes
Jul 2, 2025
Merged

feat: gradle module metadata#1506
Sam Gammon (sgammon) merged 16 commits intomainfrom
chore/lib-publishing-fixes

Conversation

@sgammon
Copy link
Member

@sgammon Sam Gammon (sgammon) commented Jun 30, 2025 •
edited
Loading

Ready for review Powered by Pull Request Badge

Summary

Bunch of general fixes and improvements, plus initial datamodel for awareness re/Gradle Module Metadata.

  • Lib Publishing Fixes
    • Fix library publishing conventions (Maven)
    • New deploy script which pushes 3p libs to Elide's Maven repo
  • Installer Enhancements
    • Installer: Source and Doc JARs #1513
    • Initial model for Gradle Module Metadata awareness
    • Add --with=sources and --with=docs to elide install
    • Fetch Gradle Module Metadata alongside POMs
  • Builder Enhancements
    • Ability to control optimization level + push/deploy state
      • Add --mode and --[no-]deploy flags to elide build
      • Honor new flags for native-image builder
      • Honor new flags for container builder

@sgammon Sam Gammon (sgammon) self-assigned this Jun 30, 2025
@sgammon Sam Gammon (sgammon) added feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge tools Issues and PRs related to tooling labels Jun 30, 2025
@sgammon Sam Gammon (sgammon) added the tools:install Things related to Elide's dependency installer label Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 15.59633% with 368 lines in your changes missing coverage. Please review.

Project coverage is 40.25%. Comparing base (4e26cf3) to head (afc6e4d).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...n/elide/tooling/jvm/gradle/GradleModuleMetadata.kt 25.75% 84 Missing and 14 partials ⚠️
...n/kotlin/elide/tooling/jvm/JvmBuildConfigurator.kt 0.00% 58 Missing ⚠️
.../elide/tooling/jvm/resolver/MavenAetherResolver.kt 0.00% 32 Missing ⚠️
...e/tooling/containers/ContainerBuildConfigurator.kt 0.00% 29 Missing ⚠️
...kotlin/elide/tool/project/DefaultProjectManager.kt 55.55% 13 Missing and 7 partials ⚠️
...e/tooling/project/manifest/ElidePackageManifest.kt 10.52% 17 Missing ⚠️
...n/kotlin/elide/tooling/config/BuildConfigurator.kt 0.00% 16 Missing ⚠️
...n/elide/tool/cli/cmd/project/ToolProjectCommand.kt 0.00% 16 Missing ⚠️
...lin/elide/tool/cli/cmd/builder/ToolBuildCommand.kt 12.50% 14 Missing ⚠️
...tooling/src/main/kotlin/elide/tooling/BuildMode.kt 0.00% 12 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   41.99%   40.25%   -1.75%     
==========================================
  Files         680      701      +21     
  Lines       31366    32775    +1409     
  Branches     4386     4557     +171     
==========================================
+ Hits        13172    13192      +20     
- Misses      16627    18040    +1413     
+ Partials     1567     1543      -24
Flag Coverage Δ
jvm 40.25% <15.59%> (-1.75%) ⬇️
lib 40.25% <15.59%> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/main/kotlin/elide/tool/cli/AbstractSubcommand.kt 58.00% <100.00%> (+0.61%) ⬆️
.../src/main/kotlin/elide/tooling/jvm/JavaCompiler.kt 0.00% <0.00%> (ø)
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 35.22% <50.00%> (-0.47%) ⬇️
...kotlin/elide/tooling/project/ProjectEnvironment.kt 0.00% <0.00%> (ø)
...lide/tooling/jvm/resolver/MavenLockfileResolver.kt 73.33% <0.00%> (ø)
...ain/kotlin/elide/tooling/lockfile/ElideLockfile.kt 0.00% <0.00%> (-34.60%) ⬇️
.../main/kotlin/elide/tooling/project/ElideProject.kt 0.00% <0.00%> (ø)
...otlin/elide/tooling/jvm/gradle/GradleAttributes.kt 28.57% <28.57%> (ø)
...n/kotlin/elide/tool/cli/cmd/deps/InstallCommand.kt 5.45% <16.66%> (+1.49%) ⬆️
...tooling/src/main/kotlin/elide/tooling/MultiPath.kt 15.74% <0.00%> (ø)
... and 14 more

... and 175 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905156a...afc6e4d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link

socket-security bot commented Jun 30, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addedmaven/​org.graalvm.sdk/​nativeimage@​24.2.13610089100100
Addedmaven/​org.graalvm.nativeimage/​objectfile@​24.2.13610089100100
Addedmaven/​org.graalvm.nativeimage/​pointsto@​24.2.13610089100100
Addedmaven/​org.graalvm.compiler/​compiler@​24.2.13610089100100
Addedmaven/​org.graalvm.nativeimage/​native-image-base@​24.2.13610089100100
Addedmaven/​org.graalvm.truffle/​truffle-enterprise@​24.2.13610089100100
Addedmaven/​org.graalvm.truffle/​truffle-runtime@​24.2.13610089100100
Addedmaven/​org.graalvm.truffle/​truffle-api@​24.2.13610089100100
Addedmaven/​org.graalvm.polyglot/​polyglot@​24.2.13610089100100
Addedmaven/​org.graalvm.sdk/​nativebridge@​24.2.14110089100100
Addedmaven/​org.graalvm.sdk/​jniutils@​24.2.16310089100100
Addedmaven/​org.graalvm.nativeimage/​library-support@​24.2.17110089100100
Addedmaven/​org.graalvm.truffle/​truffle-compiler@​24.2.17310089100100
Addedmaven/​org.graalvm.nativeimage/​svm@​24.2.110010089100100
Addedmaven/​org.graalvm.sdk/​word@​24.2.19910089100100
Addedmaven/​org.graalvm.sdk/​collections@​24.2.19910089100100
Addedmaven/​org.graalvm.polyglot/​coverage-community@​24.2.110010089100100
Addedmaven/​org.graalvm.tools/​coverage-tool@​24.2.19610089100100
Addedmaven/​org.graalvm.shadowed/​json@​24.2.19210089100100

View full report

@sgammon Sam Gammon (sgammon) force-pushed the chore/lib-publishing-fixes branch 2 times, most recently from 770aa7c to e6037b4 Compare July 1, 2025 01:51
@sgammon Sam Gammon (sgammon) changed the title [WIP] feat: gradle module metadata feat: gradle module metadata Jul 1, 2025
@sgammon Sam Gammon (sgammon) marked this pull request as ready for review July 1, 2025 14:56
@sgammon Sam Gammon (sgammon) moved this to In Progress in Elide Jul 1, 2025
sgammon
Sam Gammon (sgammon) commented Jul 1, 2025
View reviewed changes
Copy link
Member Author

@sgammon Sam Gammon (sgammon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

@claude

This comment was marked as outdated.

Sign in to view
@claude

This comment was marked as outdated.

Sign in to view
@sgammon Sam Gammon (sgammon) linked an issue Jul 2, 2025 that may be closed by this pull request
Installer: Source and Doc JARs #1513
Closed
@sgammon
fix: library publishing conventions
e15c348 
fix: publishing to local stage dir
fix: drop github repo target
fix: publishing to internal maven repo
fix: align protobuf with sigstore
chore: author poms for overridden libs
chore: publishing script for 3p libs
chore: end-to-end publishing script

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: --mode and --deploy flags for elide build
529c8c4 
feat: add `--mode` flag to `elide build`
feat: add `--deploy` flag to `elide build`
feat: honor flags for mode and deploy

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: initial gradle module metadata model
d05853c 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: 'features' block for samples config
edc6dcc 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: update api pins for builder and tooling modules
0abd934 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: injection deps for jvm
62ac633 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix: use actual container name for local tarball output
82d3a5a 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: initial support for processors
413654a 
feat: support for `processors` maven block
feat: assemble and include processor classpath
feat: greatest-common-ancestor for `--source-path`

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: resolve workspace root for projects
02dd685 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix: disable configuration cache
96d997f 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: fetch workspace from project
7b172a8 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: update api pins
cd9711c 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
feat: implement source/doc jar and module fetching
387060d 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: update api pins
b1aaa05 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
chore: disable claude code
35d179e 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon Sam Gammon (sgammon) force-pushed the chore/lib-publishing-fixes branch from 39a7a04 to 35d179e Compare July 2, 2025 15:03
@sgammon Sam Gammon (sgammon) removed the 🚧 WIP Works-in-progress. Blocks merge label Jul 2, 2025
@sgammon Sam Gammon (sgammon) requested a review from a team July 2, 2025 15:31
@sgammon Sam Gammon (sgammon) moved this from In Progress to Done in Elide Jul 2, 2025
This was linked to issues Jul 2, 2025
Telemetry shouldn't lag build/test commands #1502
Closed
elide kotlinc/javac --no-telemetry fails with an exception #1515
Closed
@sgammon
fix: disable cli telemetry
afc6e4d 
Fixes #1515
Fixes #1502

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon Sam Gammon (sgammon) force-pushed the chore/lib-publishing-fixes branch from 372aacc to afc6e4d Compare July 2, 2025 15:47
@sgammon Sam Gammon (sgammon) merged commit ce60c15 into main Jul 2, 2025
18 checks passed
@elidebot Elidebot (elidebot) mentioned this pull request Jul 19, 2025
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darvld Dario Valdespino (darvld) darvld approved these changes

Assignees

@sgammon Sam Gammon (sgammon)

Labels

feature Large PRs or issues with full-blown features tools:install Things related to Elide's dependency installer tools Issues and PRs related to tooling

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

elide kotlinc/javac --no-telemetry fails with an exception Installer: Source and Doc JARs Telemetry shouldn't lag build/test commands

2 participants

@sgammon @darvld