feat(node): support for fs.opendir[Sync]#1521
Merged
Sam Gammon (sgammon) merged 1 commit intomainfrom Jul 5, 2025
Merged
Conversation
packages/graalvm/src/main/kotlin/elide/runtime/intrinsics/js/node/fs/Dirent.kt
Outdated
Show resolved
Hide resolved
packages/graalvm/src/main/kotlin/elide/runtime/node/fs/DirectoryEntry.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
==========================================
+ Coverage 40.18% 40.41% +0.22%
==========================================
Files 701 704 +3
Lines 32850 33071 +221
Branches 4576 4599 +23
==========================================
+ Hits 13201 13364 +163
- Misses 18099 18148 +49
- Partials 1550 1559 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
feat(node): implement `fs.Dir` feat(node): implement `fs.Dirent` feat(node): implement `fs.opendir` feat(node): implement `fs.opendirSync` feat(node): implement `fs/promises.opendir` test(node): tests for `fs.opendir` and friends test(node): test for `fs/promises.opendir` chore: update `graalvm` api pins Signed-off-by: Sam Gammon <sam@elide.dev>
228ac88 to
bbc5474
Compare
Dario Valdespino (darvld)
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
node:fsmethodsopendir,opendirSync, andpromises/opendir; such methods were blocked on implementation of thefs.Dirandfs.Direntclasses, which also were added.fs.Dirfs.Direntfs#825opendir(...)opendirSync(...)fs/promises#855opendirChangelog