feat: S3 support#1611
Conversation
ea40001 to
3f423f3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage ? 39.98%
=======================================
Files ? 783
Lines ? 37433
Branches ? 5295
=======================================
Hits ? 14969
Misses ? 20675
Partials ? 1789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Nathan <nate.hak@gmail.com>
3f423f3 to
79ecfd9
Compare
Sam Gammon (sgammon)
left a comment
There was a problem hiding this comment.
great work, especially on tests 👍
| private val jsObj: Map<String, Any> = mapOf( | ||
| "write" to ProxyExecutable { args -> |
There was a problem hiding this comment.
this is good, but even better:
private val jsObj: Map<String, Any> = buildMap {
this["write"] = ProxyExecutable { ... }
}using buildMap allows you to establish a new block, which is more flexible than an arg suite
anyway you don't need to update this particular code, it's just good to know for later 👍
5a2cc4e
into
elide-dev:main
Summary
Added S3 support to javascript environments for S3 and other compatible APIs
Changelog