fix: --js:strict and benchmark symbols#1668
Merged
Dario Valdespino (darvld) merged 5 commits intomainfrom Sep 24, 2025
Merged
Conversation
Fixes: #1667 Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 40.58% 40.59%
=======================================
Files 798 799 +1
Lines 37803 37813 +10
Branches 5387 5387
=======================================
+ Hits 15344 15351 +7
- Misses 20633 20637 +4
+ Partials 1826 1825 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes: #1665 Signed-off-by: Sam Gammon <sam@elide.dev>
6ec1275 to
b5f3a29
Compare
Dario Valdespino (darvld)
approved these changes
Sep 24, 2025
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Merged
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds necessary support infra to be able to run
js-benchmarkson Elide.--js:stricthas no effect #1667