Skip to content

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Jun 7, 2025

Summary

Adds initial CI jobs on-push and on-PR.

Changelog

chore: add build job
chore: add pr job hook
chore: add push job hook

chore: add build job
chore: add pr job hook
chore: add push job hook

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon requested review from a team and Copilot June 7, 2025 20:14
@sgammon sgammon self-assigned this Jun 7, 2025
@sgammon sgammon added dev Dev tools, CI/CD, and other devops topics enhancement New feature or request labels Jun 7, 2025
@sgammon sgammon added this to Elide Jun 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds initial CI workflows for push and pull request events by introducing two trigger files and a reusable build workflow.

  • Introduce on.push.yml to trigger CI on pushes to main
  • Introduce on.pr.yml to trigger CI on all pull requests
  • Add job.build.yml as a reusable build workflow with Maven and Gradle steps

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/on.push.yml Defines push trigger for main to call the build job
.github/workflows/on.pr.yml Defines PR trigger to call the build job
.github/workflows/job.build.yml Implements reusable build workflow steps
Comments suppressed due to low confidence (1)

.github/workflows/on.push.yml:1

  • [nitpick] Consider renaming this file to on-push.yml (and on.pr.yml to on-pr.yml) to align with common GitHub Actions naming conventions and avoid confusion with the file extension.
.github/workflows/on.push.yml

Comment on lines +1 to +19
name: "CI"

"on":
push:
branches:
- main

permissions:
contents: "read"

jobs:
build:
name: "Build"
uses: ./.github/workflows/job.build.yml
secrets: inherit
permissions:
contents: "read"
with:
runner: "ubuntu-latest"
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove unnecessary double quotes around static values (e.g., name: CI) and keys to improve YAML readability and consistency.

Suggested change
name: "CI"
"on":
push:
branches:
- main
permissions:
contents: "read"
jobs:
build:
name: "Build"
uses: ./.github/workflows/job.build.yml
secrets: inherit
permissions:
contents: "read"
with:
runner: "ubuntu-latest"
name: CI
on:
push:
branches:
- main
permissions:
contents: read
jobs:
build:
name: Build
uses: ./.github/workflows/job.build.yml
secrets: inherit
permissions:
contents: read
with:
runner: ubuntu-latest

Copilot uses AI. Check for mistakes.
jobs:
build:
name: "Maven Plugin"
runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since runner has a default value in the workflow_call inputs, you can simplify this to runs-on: ${{ inputs.runner }} without the fallback.

Suggested change
runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
runs-on: ${{ inputs.runner }}

Copilot uses AI. Check for mistakes.
@melodicore melodicore merged commit a63a444 into main Jun 7, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this to Done in Elide Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Dev tools, CI/CD, and other devops topics enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants