-
Notifications
You must be signed in to change notification settings - Fork 0
chore: initial ci jobs #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: add build job chore: add pr job hook chore: add push job hook Signed-off-by: Sam Gammon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds initial CI workflows for push and pull request events by introducing two trigger files and a reusable build workflow.
- Introduce
on.push.ymlto trigger CI on pushes tomain - Introduce
on.pr.ymlto trigger CI on all pull requests - Add
job.build.ymlas a reusable build workflow with Maven and Gradle steps
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/on.push.yml | Defines push trigger for main to call the build job |
| .github/workflows/on.pr.yml | Defines PR trigger to call the build job |
| .github/workflows/job.build.yml | Implements reusable build workflow steps |
Comments suppressed due to low confidence (1)
.github/workflows/on.push.yml:1
- [nitpick] Consider renaming this file to
on-push.yml(andon.pr.ymltoon-pr.yml) to align with common GitHub Actions naming conventions and avoid confusion with the file extension.
.github/workflows/on.push.yml
| name: "CI" | ||
|
|
||
| "on": | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: "read" | ||
|
|
||
| jobs: | ||
| build: | ||
| name: "Build" | ||
| uses: ./.github/workflows/job.build.yml | ||
| secrets: inherit | ||
| permissions: | ||
| contents: "read" | ||
| with: | ||
| runner: "ubuntu-latest" |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove unnecessary double quotes around static values (e.g., name: CI) and keys to improve YAML readability and consistency.
| name: "CI" | |
| "on": | |
| push: | |
| branches: | |
| - main | |
| permissions: | |
| contents: "read" | |
| jobs: | |
| build: | |
| name: "Build" | |
| uses: ./.github/workflows/job.build.yml | |
| secrets: inherit | |
| permissions: | |
| contents: "read" | |
| with: | |
| runner: "ubuntu-latest" | |
| name: CI | |
| on: | |
| push: | |
| branches: | |
| - main | |
| permissions: | |
| contents: read | |
| jobs: | |
| build: | |
| name: Build | |
| uses: ./.github/workflows/job.build.yml | |
| secrets: inherit | |
| permissions: | |
| contents: read | |
| with: | |
| runner: ubuntu-latest |
| jobs: | ||
| build: | ||
| name: "Maven Plugin" | ||
| runs-on: ${{ inputs.runner || 'ubuntu-latest' }} |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since runner has a default value in the workflow_call inputs, you can simplify this to runs-on: ${{ inputs.runner }} without the fallback.
| runs-on: ${{ inputs.runner || 'ubuntu-latest' }} | |
| runs-on: ${{ inputs.runner }} |
Summary
Adds initial CI jobs on-push and on-PR.
Changelog