Skip to content

php 8.1 support#846

Draft
lsh-0 wants to merge 1 commit intodevelopfrom
php8-1-support
Draft

php 8.1 support#846
lsh-0 wants to merge 1 commit intodevelopfrom
php8-1-support

Conversation

@lsh-0
Copy link
Contributor Author

lsh-0 commented Mar 21, 2023

current state of composer update [on php 8.1] after these changes:

Screenshot at 2023-03-21 16-42-04

  - Applying patches for drupal/entity_reference_revisions
    https://www.drupal.org/files/issues/entity_reference_revisions-stop_checking_for_entities_before_generating_sample-2910326-2.patch (Allow entities to be generated if none exist (2910326))
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/entity_reference_revisions-stop_checking_for_entities_before_generating_sample-2910326-2.patch

In Patches.php line 331:
                                                                                                                                                  
  Cannot apply patch Allow entities to be generated if none exist (2910326) (https://www.drupal.org/files/issues/entity_reference_revisions-stop  
  _checking_for_entities_before_generating_sample-2910326-2.patch)!                                                                               
                                                                                                                                                  

@nlisgo
Copy link
Member

nlisgo commented Mar 22, 2023

I will schedule time to look at this either today or tomorrow.

@nlisgo
Copy link
Member

nlisgo commented Mar 23, 2023

Looking like Friday now.

@lsh-0
Copy link
Contributor Author

lsh-0 commented Mar 23, 2023

That's alright, I didn't ping you because I was going to try tackling it myself before sending it your way.

I'm not sure how you could easily recreate this error but you might have some insight into any changes I need to make to composer.

Alternately I could set up an instance like the 8032 one and you could QA how Drupal and php 8.1 play together.

@nlisgo
Copy link
Member

nlisgo commented Mar 24, 2023

I started looking at this but haven't been able to complete. Will carry this on next week.

@nlisgo
Copy link
Member

nlisgo commented Mar 24, 2023

Alternately I could set up an instance like the 8032 one and you could QA how Drupal and php 8.1 play together.

Happy with either approach.

@lsh-0
Copy link
Contributor Author

lsh-0 commented Apr 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants