1.3.1 Merge #101
Open
1.3.1 Merge #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remediation and cleanup for 1.3.1 fixes
Tweaked grammar for restoring old outlook function to use proper PS prefix
Few tweaks, and finally solved our issues in #87 !
Prepped version rollover for security support in 1.3.1
Added passthru elevation of #97
Removed duplicate SFC toolbox option. Production location will now be under the "Windows" tab
As a part of general review in #98 , squashed some bugs regarding how the Outlook repair tool runs.
Modified and added error handling to the outlook legacy rollback
Signed-off-by: Eli Weitzman <[email protected]>
Changed the copyright year in the license header from 2024-2025 to 2025 to reflect the current year.
Co-authored-by: eliweitzman <[email protected]>
Co-authored-by: eliweitzman <[email protected]>
- Resolved merge conflicts by integrating 1.3.1-Dev changes into configurable tab ordering system - Updated tab creation functions to include new features from 1.3.1-Dev: - Added new Outlook functions to Actions tab - Enhanced Windows tab with DISM scan and Group Policy functions - Updated Security tab with Windows Defender scan functions - Enhanced SCCM tab with specific client functions - Updated AD tab with new AD Explorer and Bitlocker functions - Updated Custom tab with enhanced custom function processing - Maintained configurable tab ordering functionality - Included keyboard shortcut for Exit button using Escape key - Updated copyright year to 2025
[Enhancement] Add configurable tab ordering for toolbox tabs
… and improve code formatting
Owner
Author
|
Finding an additional bug... somehow the interactivity for the toolbox functions is now lost - no longer triggers events. Digging into this |
This reverts commit f6ae920.
This reverts commit 628e96c.
Due to buggy code, rolling back and removing tab reordering - will fix CIM compliance next
Updated ETT.ps1 and ToolboxFunctions.ps1 to use Get-CimInstance instead of the deprecated Get-WmiObject for querying system information. This improves compatibility and performance with newer versions of PowerShell.
Owner
Author
|
Fixing Copilot's new review now and testing functionality |
Replaced string comparison ($adminmode -eq "True") with boolean comparison ($adminmode -eq $true) in multiple functions to ensure proper admin mode detection and improve code reliability.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the EnterpriseTechTool (ETT) to version 1.3.1, introducing several improvements for maintainability, configurability, and user experience. The update modernizes system information gathering by replacing deprecated WMI calls with CIM instances, enhances notification handling with a reusable toast function, and expands functionality with new system repair and Outlook management tools.
Key changes include:
- Version bump to 1.3.1 with updated copyright year and support documentation
- Replacement of deprecated
Get-WmiObjectcalls with modernGet-CimInstancethroughout the codebase - Introduction of a centralized
Create-ToastNotificationfunction for consistent notification handling - Addition of new system repair functions (DISM scan, Group Policy cache deletion) and Outlook management tools
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| ETT.ps1 | Main script updated to v1.3.1 with modernized WMI calls, new toast notification function, and enhanced update handling |
| PSAssets/ToolboxFunctions.ps1 | Added new system repair and Outlook management functions, modernized existing functions, and improved error handling |
| LICENSE | Updated copyright year to include 2025 |
| .github/SECURITY.md | Updated version support table to reflect v1.3.1 as current supported version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Eli Weitzman <[email protected]>
Introduces .github/copilot-instructions.md with guidance for AI agents and developers working on the Windows PowerShell application. Covers project structure, workflows, conventions, integration points, editing examples, compilation steps, and troubleshooting tips.
Added more specific error messages and user guidance in SettingsMenu.ps1 for cases where the settings menu is disabled or not referenced in the config, including an option to open the GitHub repository for the latest config. In ETT.ps1, updated the copyright year and improved robustness of Toolbox tab creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the EnterpriseTechTool (ETT) PowerShell script to version 1.3.1, introducing several improvements for maintainability, configurability, and user experience. The most significant changes include version and support updates, a refactor of the toolbox tab creation for configurable ordering, enhancements to update notifications, and modernization of system information gathering. Below are the top changes grouped by theme:
Versioning and Support
1.3.1and copyright year to 2025 inETT.ps1; updated the support table in.github/SECURITY.mdto reflect end-of-life and support for versions 1.3 and 1.3.1. [1] [2] [3]Configurability and Maintainability
Create-ActionsTab,Create-WindowsTab, etc.) and introduced$tabOrderfor customizable tab ordering, improving code maintainability and user configurability. [1] [2] [3] [4]User Experience Improvements
Create-ToastNotificationfunction for toast notifications, replacing previous inline notification logic and improving notification handling consistency. [1] [2]Modernization and Performance
Get-WmiObjectcalls withGet-CimInstancethroughout the script for improved performance and compatibility with newer PowerShell versions. [1] [2] [3] [4] [5]Minor Cleanups