Conversation
Reviewer's Guide by SourceryThis pull request updates the TES models to version 1.1 by adding new fields and modifying existing ones in File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
uniqueg
left a comment
There was a problem hiding this comment.
Looks good to me. However, the one open Sourcery AI comment looks reasonable - although I have no clue if their suggested change works. Maybe you can try it out and either replace or comment on why it didn't work
|
Also - tests fail... |
|
I think the rest of the linting and integration tests will pass once #178 is merged. |
|
LGTM, @athith-g - I think you can merge :) |
* feat: add ignore_error to TesExecutor * feat: add backend_parameters and backend_parameters_strict to TesResources * feat: add new tesStates * refactor: make TesFileType optional * feat: add streamable to TesInput * refactor: avoid string literal * fix: shorten doc line lengths * fix: change example to examples --------- Co-authored-by: Alex Kanitz <alexander.kanitz@unibas.ch>
Details
Added fields that were added in TES v1.1 to
models.pyTES v1.1 changes:
models.pymodels.pyI removed the unnecessary newlines but I'm not sure how to achieve the whitespacing in the existing descriptions.
Summary by Sourcery
Updated TES models to v1.1 by adding new fields and states to support the latest features and configurations as per the TES v1.1 specification.