Skip to content

Use unique tmp file names to avoid race conditions #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Aug 21, 2025
Merged

Use unique tmp file names to avoid race conditions #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/explorer/polars_backend/shared.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ defmodule Explorer.PolarsBackend.Shared do
Builds and returns a path for a new file.

It saves in a directory called "elixir-explorer-datasets" inside
the `System.tmp_dir()`.
the `System.tmp_dir()`, the file name contains a random component to avoid collisions.
"""
def build_path_for_entry(%FSS.S3.Entry{} = entry) do
bucket = entry.config.bucket || "default-explorer-bucket"
Expand All @@ -278,15 +278,18 @@ defmodule Explorer.PolarsBackend.Shared do
:crypto.hash(:sha256, entry.config.endpoint <> "/" <> bucket <> "/" <> entry.key)
|> Base.url_encode64(padding: false)

id = "s3-file-#{hash}"
rand = Base.url_encode64(:crypto.strong_rand_bytes(8), padding: false)

id = "s3-file-#{hash}-#{rand}"

build_tmp_path(id)
end

def build_path_for_entry(%FSS.HTTP.Entry{} = entry) do
hash = :crypto.hash(:sha256, entry.url) |> Base.url_encode64(padding: false)
rand = Base.url_encode64(:crypto.strong_rand_bytes(8), padding: false)

id = "http-file-#{hash}"
id = "http-file-#{hash}-#{rand}"

build_tmp_path(id)
end
Expand Down
Loading