Skip to content

Switching to good drive before moving in directory #13821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −0
Closed

Switching to good drive before moving in directory #13821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/mix/lib/mix/tasks/release.init.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ defmodule Mix.Tasks.Release.Init do
setlocal enabledelayedexpansion
pushd .
%~d0
cd "%~dp0\.."
set RELEASE_ROOT=%cd%
popd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been reading the docs and it seems this would also work:

pushd "%~dp0\.."
set RELEASE_ROOT=%cd%
popd

Because, opposite to cd, pushd changes the path. can you please give it a try too? ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works well too.
And it seems little bit cleaner than playing with old "dos" command.

I'll do another pull request

Expand Down
Loading