Moving to good directory with good drive on windows #13825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 13, 2024
| pushd "%~dp0\.." | ||
| set RELEASE_ROOT=%cd% | ||
| popd | ||
| popd |
There was a problem hiding this comment.
Do we need this popd too or can we remove it?
Suggested change
| popd |
There was a problem hiding this comment.
I don't know.
But seemed obvious for me that one pushd - one popd
There was a problem hiding this comment.
Tried a little script :
cd
pushd "c:\temp"
cd
pushd "d:\src"
cd
popd
cd
popd Without the second popd, I'm still in then C:\temp and not restored in the original directory where a launch it.
So I'l say Yes , we need the second too.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pushd that takes consideration for the drive in the path, when it is different form where the command is launch.
Reference to #13820