Map.pop!/2 description modification #13834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 17, 2024
| Removes the value associated with `key` in `map` and returns the value | ||
| and the updated map, or it raises if `key` is not present. | ||
| Removes and returns the value associated with `key` in `map` alongside | ||
| the updated map, or raises if `key` is not present. |
There was a problem hiding this comment.
I changed this sentence because it should be remain small but kept the rest. :)
There was a problem hiding this comment.
Suggested change
| the updated map, or raises if `key` is not present. | |
| the updated map, or raises a `KeyError` exception if `key` is not present. |
Ok, but "raises what if"? I guess there should be something or that part can be skipped since in line 715 it is mentioned that this function raises error when key is not present
There was a problem hiding this comment.
"raises" in Elixir is always about exceptions. The details of which exception can be found in the next paragraph. :)
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to description of Map.pop!/2