Various small improvements in guides and docs #13887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 8, 2024
| iex> +0.0 == -0.0 | ||
| true | ||
| ``` | ||
There was a problem hiding this comment.
I am not sure I want to go into this level of distinction for a getting started guide. I would just remove the note and leave the content as it was, and we can mention the differences in the === and !== docs.
In particular, IEEE recommends +0.0 and -0.0 to actually be equal. But === is about "are they the same term"?
josevalim
reviewed
Oct 8, 2024
josevalim
approved these changes
Oct 8, 2024
Co-authored-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf individual commits for more details