Skip to content

Simplify Integer.digits/2 and Integer.undigits/2 #13899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2024
Merged

Simplify Integer.digits/2 and Integer.undigits/2 #13899

merged 3 commits into from
Oct 13, 2024

Conversation

MikaelFangel
Copy link
Contributor

@MikaelFangel MikaelFangel commented Oct 13, 2024 •
edited
Loading

This pr simplifies digits and undigits and removes some guard clauses.

Changes

  • Removes redundant do_ from the function heads which are separated by their arity anyway.
  • Simplify guard clauses

Performance results

Screenshot 2024-10-13 at 14 14 00

sabiwara
sabiwara reviewed Oct 13, 2024
View reviewed changes
sabiwara
sabiwara reviewed Oct 13, 2024
View reviewed changes
sabiwara
sabiwara approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@sabiwara sabiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion otherwise looks good and indeed simpler.
No strong opinion on the do_ thing, arity differences are sometimes less easy to spot.

@MikaelFangel
Copy link
Contributor Author

Sorry, I forgot to check the formatting.

@sabiwara
Copy link
Contributor

Screenshot 2024-10-13 at 23 23 48

Looks solid! ⚡ Great job @MikaelFangel

@sabiwara sabiwara merged commit 0c7459e into elixir-lang:main Oct 13, 2024
9 checks passed
@MikaelFangel
Copy link
Contributor Author

Thank you 🥳

@MikaelFangel MikaelFangel deleted the simplify_integer_digits branch October 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabiwara sabiwara sabiwara approved these changes

@josevalim josevalim josevalim approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikaelFangel @sabiwara @josevalim