Skip to content

Conversation

jonatanklosko
Copy link
Member

Adds Mix.Task.Compiler.diagnostics() that fetches all warning diagnostics persisted by each compiler in its manifest.

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I think we only need a test for Mix.Task.Compiler.diagnostics and we are good to go. We can probably just add a few lines to one test in compile.elixir and compile.erlang that makes sure it is included there too.

@jonatanklosko
Copy link
Member Author

@josevalim done!

@josevalim josevalim merged commit 9c42348 into elixir-lang:main Oct 16, 2024
9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants